Repository navigation
Conversation
Pepps233
changed the title
Issacboy123
left a comment
Issacboy123
left a comment
There was a problem hiding this comment.
Separating Shift+Tab toggling, /plan <instructions>, and pending-plan decisions improves the interactive flow and fixes PR #87's missing selector. Two state boundaries are still conflated: transformed plan input is written to history, and border color lives on the active editor. Keep raw input, dispatched prompts, and history distinct, then reapply derived appearance whenever the active editor changes.
| this.editor.setText(""); | ||
| const planningPrompt = await this.handlePlanCommand(instructions); | ||
| if (planningPrompt === undefined) return; | ||
| text = planningPrompt; |
There was a problem hiding this comment.
Replacing text here also changes what the later addToHistory() call records. After plan mode ends, recalling this entry submits the instructions as an ordinary write-capable prompt. Please retain the original /plan command for history and use planningPrompt only for dispatch.
| if (this.isBashMode) { | ||
| this.editor.borderColor = theme.getBashModeBorderColor(); | ||
| } else if (this.session.collaborationMode === "plan") { | ||
| this.editor.borderColor = theme.getPlanModeBorderColor(); |
There was a problem hiding this comment.
This updates only the currently active editor. If collaboration mode changes while a custom editor is mounted, restoring the default editor reuses its previous border color. I think you should recompute the border after installing or restoring an editor, or derive it from current mode when mounting.
|
Fixed by Diffex Issue:
Issue: The compaction queue recorded transformed plan instructions instead of the original
Issue: Plan-mode border updates applied only to the active custom editor. Restoring the default editor could therefore reuse a stale border from the previous collaboration mode.
Issue: Plan mode used the fixed
|
2 participants
Summary
Improve the interactive plan-mode workflow and move thinking-effort selection into
/model.Changes
/plan [instructions]as a planning prompt and remove theon/offcontrolsapp.plan.toggleplan-mode toggling#6FB01Ceditor border while plan mode is active, with an optionalplanModetheme token/modelor Ctrl+L/settingsUser impact
/plan onand/plan offare no longer mode controls; their arguments are treated as planning instructionsapp.thinking.cycleis replaced byapp.plan.toggle#6FB01Cplan-mode fallback unless they defineplanModeValidation
npm run check./test.sh